Open
Conversation
Contributor
ThibaudGLT
commented
Mar 18, 2026
ThibaudGLT
commented
- Add a collapse button with specific label setting
- Fix behavior when search is updated with new selected facet
- Add reset button
- Change filter button icon
- Add a collapse button with specific label setting - Fix behavior when search is updated with new selected facet - Add reset button - Change filter button icon
jajm
requested changes
Mar 19, 2026
Replace the single toggle button (whose icon and label were changed via JS) with two separate buttons (expand and collapse), shown/hidden via CSS only. This also fixes an XSS vulnerability when data-*-label contained HTML tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.